Additional functions.#10
Open
AnnaYasenova wants to merge 2 commits intoHowProgrammingWorks:masterfrom
Open
Conversation
tshemsedinov
requested changes
Mar 5, 2017
Member
tshemsedinov
left a comment
tshemsedinov
left a comment
There was a problem hiding this comment.
Много где можно заменить let на const. Проведи через eslint
JavaScript/4-newfunc.js
Outdated
|
|
||
| (function recursive(currNode) { | ||
|
|
||
| let len = currNode.child.length, |
Member
There was a problem hiding this comment.
const len = currNode.child.length;
JavaScript/4-newfunc.js
Outdated
| (function recursive(currNode) { | ||
|
|
||
| let len = currNode.child.length, | ||
| num; |
JavaScript/4-newfunc.js
Outdated
|
|
||
| Tree.prototype.addData = function(name, data, whereAdd) { | ||
| let parent = null, | ||
| callback = function(n) { |
tshemsedinov
reviewed
Mar 6, 2017
|
|
||
| Tree.prototype.visitDepth = function(callback) { | ||
|
|
||
| (function recursive(currNode) { |
Member
There was a problem hiding this comment.
What is a purpose of this IIFE (immediately-invoked function expression) ?
Author
There was a problem hiding this comment.
На парі показали такий варіант реалізації - вирішила спробувати, не більше того.
| })(this.root); | ||
| }; | ||
|
|
||
| Tree.prototype.isHave = function(callback) { |
Member
There was a problem hiding this comment.
Tree.has(node) returns boolean, no need callback but where is node argument to check?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented next methods: visitDepth, isHave, addData.