Homework tasks#2
Open
ALEGATOR1209 wants to merge 6 commits intoHowProgrammingWorks:masterfrom
ALEGATOR1209:master
Open
Homework tasks#2ALEGATOR1209 wants to merge 6 commits intoHowProgrammingWorks:masterfrom ALEGATOR1209:master
ALEGATOR1209 wants to merge 6 commits intoHowProgrammingWorks:masterfrom
ALEGATOR1209:master
Conversation
JavaScript/8-timer.js
Outdated
| @@ -0,0 +1,47 @@ | |||
| 'use strict'; | |||
JavaScript/8-timer.js
Outdated
|
|
||
| const setTimer = msec => { | ||
| timer = setTimeout(() => { | ||
| console.log('Cache cleaned'); |
JavaScript/8-timer.js
Outdated
| }, msec); | ||
| }; | ||
|
|
||
| const generateKey = (...args) => args.join('|'); |
JavaScript/8-timer.js
Outdated
|
|
||
| return (...args) => { | ||
| if (!timer) setTimer(msec); | ||
| const key = generateKey(...args); |
Member
There was a problem hiding this comment.
Pass array to generateKey to avoid arguments repack
JavaScript/8-timer.js
Outdated
|
|
||
| console.log(`Calculate: ${args} = ${fn(...args)}`); | ||
| const res = fn(...args); | ||
| cache[key] = res; |
Member
There was a problem hiding this comment.
Do not write undefined to cache
JavaScript/8-timer.js
Outdated
| if (!timer) setTimer(msec); | ||
| const key = generateKey(...args); | ||
|
|
||
| if (cache[key]) { |
Member
There was a problem hiding this comment.
Check type, aware of 0, false and empty string
| const length = size.length; | ||
| const data = parseFloat(size, 10); | ||
| let k = 1; | ||
| switch (size.charAt(length - 1)) { |
Member
There was a problem hiding this comment.
Use new Map or {} for large cases
JavaScript/a-bytes.js
Outdated
| let bytes = 0; | ||
| for (const i in obj) { | ||
| switch (typeof obj[i]) { | ||
| case 'number': |
Member
There was a problem hiding this comment.
{
number: 8,
boolean: 4
....
}
JavaScript/a-bytes.js
Outdated
|
|
||
| console.log(`Calculating: ${key}`); | ||
| cache[key] = fn(...args); | ||
| console.dir(`Cache size: ${getSize(cache)}`); |
Member
There was a problem hiding this comment.
Calculate getSize(cache) once
Author
|
Problems solved. @tshemsedinov review, please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.