-
Notifications
You must be signed in to change notification settings - Fork 520
Refactor structure of project and bump plugins #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor structure of project and bump plugins #657
Conversation
skybber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good, please check the review issues.
hotswap-agent-core/src/main/java/org/hotswap/agent/HotswapAgent.java
Outdated
Show resolved
Hide resolved
fb45843 to
5059b08
Compare
skybber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm not able to compile HA now:
JAVA_HOME=/usr/lib/jvm/jbrsdk-21-snapshot mvn clean package -DSpringReloadDelayMillis=800 -DSpringTestSleepTimeFactor=0.4
ends up with:
[INFO] hotswap-agent-proxy-plugin ......................... FAILURE [ 0.012 s]
INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:04 min
[INFO] Finished at: 2025-11-02T22:03:08+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.p
lugins:maven-compiler-plugin:3.14.1:compile (default-compile) on project hotswap-agent-proxy-plugin: Fatal error compiling: error: option --add-exports not allowed with target 8 -> [Help 1]
|
I'm not sure if we can drop java8 support now... |
be975b4 to
6d78478
Compare
|
Fixed — it now builds successfully with JDK 21. In fact, two tests from MyBatis are still failing, but they also failed with the previous approach. (at least on Linux Mint 22.2 Zara |
6d78478 to
1c04d74
Compare
|
Thanks, that already looks good now, btw are you planning to continue contributing to HotswapAgent? |
|
I can’t promise, but I recently discovered this project, and we’ve started using it — I really like it. It works much better for large Spring monolith projects than Spring Reloaded/devtools. |
|
It seems that JMock is being replaced by Mockito, so it’s worth making the switch. |
Hello, I've refactored structure of project and bumped maven plugins.

Why?
Now it's can be build with jdk11,17 (fixed profiles)
You can run tests directly from IDE. (only with agent build with jdk 17(change target and source to 17 in pom), with 11 IJ is throwing
Type 'java/io/IOException' (constant pool 55) "is not assignable to 'java/lang/Throwable"