Script to install elastic agent #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 OpenAI Chat with 🤖 OpenAI Bot (
|
Contributor
ProfessorManhattan
left a comment
ProfessorManhattan
left a comment
There was a problem hiding this comment.
Couple requests
home/.chezmoiscripts/universal/run_onchange_after_57-elastic-agent.sh.tmpl
Show resolved
Hide resolved
ProfessorManhattan
requested changes
Jul 9, 2023
Contributor
ProfessorManhattan
left a comment
ProfessorManhattan
left a comment
There was a problem hiding this comment.
Please address the comments on this one
ProfessorManhattan
requested changes
Jul 9, 2023
Contributor
ProfessorManhattan
left a comment
ProfessorManhattan
left a comment
There was a problem hiding this comment.
Please install Elastic Agent as well.
home/.chezmoiscripts/universal/run_onchange_after_57-elastic-agent.sh.tmpl
Show resolved
Hide resolved
enggnr
commented
Jul 10, 2023
Contributor
Author
enggnr
left a comment
enggnr
left a comment
There was a problem hiding this comment.
Review comments incorporated
ProfessorManhattan
force-pushed
the
26_elasticagent
branch
from
06c0429 to
2dfb30a
Compare
ProfessorManhattan
requested changes
Jul 19, 2023
home/.chezmoiscripts/universal/run_onchange_after_57-elastic-agent.sh.tmpl
Show resolved
Hide resolved
enggnr
commented
Jul 19, 2023
Contributor
Author
enggnr
left a comment
enggnr
left a comment
There was a problem hiding this comment.
Looks like I didn't push the changes, should be good now.
ProfessorManhattan
force-pushed
the
26_elasticagent
branch
from
cd2a814 to
2dfb30a
Compare
ProfessorManhattan
requested changes
Aug 1, 2023
Contributor
ProfessorManhattan
left a comment
ProfessorManhattan
left a comment
There was a problem hiding this comment.
Please update this to use SRV records / auto-discovery like glusterfs / etcd
home/.chezmoiscripts/universal/run_onchange_after_57-elastic-agent.sh.tmpl
Show resolved
Hide resolved
ProfessorManhattan
force-pushed
the
master
branch
from
1b9360e to
b385d17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR provides a script that conditionally enrolls elastic agent with Elastic fleet server
What is the current behavior? (You can also link to an open issue here)
Elastic agent is not automatically enrolled
What is the new behavior (if this is a feature change)?
Fixes Add device with
elastic-agent#26