fix: drop redundant named export on service singletons - #15
Merged
Conversation
Each service module exported its singleton both as a named export and as the default export, and every consumer imported the default - eslint-plugin-import flagged the unused named export as an import/no-named-as-default ambiguity risk on every import site (30 warnings across hooks, screens, and tests). No file actually consumed the named export, so dropping it resolves the warning at the source instead of at each of the ~20 call sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/api/services/*.tsmodule exported its singleton both as a named export (export const xService = ...) and as the default export, while every consumer (hooks, screens, tests) imported it as default.eslint-plugin-import'simport/no-named-as-defaultflagged this as an ambiguity risk at every one of the ~20 import sites (30 warnings total).exportfrom the singleton declaration in each of the 10 service files, keeping only the default export. No import site changes needed.Test plan
npx expo lint --no-cache— the 30import/no-named-as-defaultwarnings for these services are gone (57 → 21 remaining warnings, all unrelated)npm run typecheck— cleannpm test— 610/610 passingNote: this branch is based on
main, which still has the 4 pre-existingreact-hooks/set-state-in-effectlint errors also visible innpx expo lintoutput — those are already fixed on the separate, still-open PR #14 and out of scope here.