Skip to content

Resolved double names, renamed imported library to expressWsLib#66

Open
Brampage wants to merge 1 commit intoHenningM:masterfrom
Brampage:patch-1
Open

Resolved double names, renamed imported library to expressWsLib#66
Brampage wants to merge 1 commit intoHenningM:masterfrom
Brampage:patch-1

Conversation

@Brampage
Copy link

No description provided.

@joepie91
Copy link
Collaborator

Thanks for your PR!

This is indeed an issue that needs to be solved, but I think that renaming the instance to expressWsInstance or such and leaving the library itself as expressWs would be a better way to solve it - this would be in line with the convention in Node.js to store a require()d library in a variable named after itself.

Thoughts?

@joepie91 joepie91 self-assigned this Mar 17, 2017
@Brampage
Copy link
Author

You're welcome :)
Yes, that sounds better to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants