Fix default language not applied

[guillaumearnx]

SECRET_FORCED_LANGUAGE is not applied because fallbackLng works only when detection method failed.

Summary by CodeRabbit

• Refactor
  • Updated language initialization settings to directly specify the initial language, improving clarity of language selection behavior.

[coderabbitai]

Walkthrough

The initialization of the i18next instance in the client was updated by replacing the use of the fallbackLng configuration option with the lng option, directly setting the initial language to a forced value from the configuration. No other options or exported entities were changed.

Changes

File(s)	Change Summary
client/i18n.js	Replaced fallbackLng with lng in i18next initialization to set the initial language directly.

Poem

In the warren of code, a language switch,
From fallback to initial—such a simple twitch!
Now i18next knows which tongue to choose,
No fallback guessing, no time to lose.
A hop, a skip, a language set,
This bunny’s happy—no regrets yet! 🐇

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

client/i18n.js (2)

8-15: Consider adding validation for the forced language value.

While the current implementation works, it would be more robust to validate the forced language value to handle edge cases like empty strings or invalid language codes.

 function getLanguage() {
-    const language = config.get('settings.forcedLanguage');
+    const forcedLanguage = config.get('settings.forcedLanguage');
+    const language = forcedLanguage && forcedLanguage.trim() ? forcedLanguage : null;
     const detectionMethod = ['navigator'];
 
     return { language, detectionMethod };
 }

This ensures that empty or whitespace-only forced language values fall back to detection rather than potentially causing i18next issues.

---

23-25: Consider documenting the detection fallback behavior.

The detection configuration is still present, which is good for cases where no forced language is set. However, this dual behavior (forced vs. detected) could benefit from a clarifying comment.

+        // Language detection is used only when no forced language is configured
         lng: language,
         detection: {
             order: detectionMethod,
         },

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4cdaaa5 and b1699f7.

📒 Files selected for processing (1)

• client/i18n.js (1 hunks)

🔇 Additional comments (1)

client/i18n.js (1)

22-22: ```shell
#!/bin/bash
sed -n '1,200p' client/i18n.js

</details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

[bjarneo]

Thank you!

Did you verify the cases locally?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud