serde macro cleanups #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lschmierer
force-pushed
the
serde-cleanup
branch
from
aba06c1 to
df092f8
Compare
smunini
reviewed
Nov 22, 2025
Contributor
smunini
left a comment
smunini
left a comment
There was a problem hiding this comment.
Excellent changes. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
serde_helpersmod was actually already inlined into the macro - I removed that file.Additionally I replaced the generated
__HeliosEmptySerializerwith a plainis_emptymethod. I think this is simpler to understand and might be even more performant (would still prefer that over a few precent performance difference).