Skip to content

Conversation

@smunini
Copy link
Contributor

@smunini smunini commented Nov 20, 2025

No description provided.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 91.03774% with 38 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/fhir/src/serde_helpers.rs 90.19% 35 Missing ⚠️
crates/fhir-gen/src/lib.rs 94.23% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@lschmierer
Copy link
Contributor

lschmierer commented Nov 20, 2025

I have seen that (also on the other branch) the integration test failed for that last „do not serialize into serde_json Value“ commit.
I would like to rework that to avoid this separate serde_helpers module and make the derive self contained. I will have time to look into that this weekend.

@smunini
Copy link
Contributor Author

smunini commented Nov 20, 2025

I "think" I have applied a fix for that. About to post a lengthy response to you back on #22 momentarily.

smunini and others added 7 commits November 20, 2025 18:41
Port the serialize null check optimization from commit 357e0ac.
Replace serde_json::to_value() based empty checks with a custom
__helios_serde_is_empty serializer that detects emptiness by
traversing the serialization without creating JSON values.

This avoids allocation overhead for empty/null field checks.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Lukas Schmierer <[email protected]>
@smunini smunini merged commit 0fff0f4 into main Nov 21, 2025
36 of 37 checks passed
@smunini smunini deleted the lukas/cherry-pick branch November 29, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants