Claim chat feature. KMPify everything related to this in the process (GEN-4661) #2729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move Android specific items to androidMain
Use R.string for cases where context.resources was used to access them to avoid having to do runBlocking or find a way to get into a composable context
# Conflicts: # app/feature/feature-terminate-insurance/src/main/kotlin/com/hedvig/android/feature/terminateinsurance/step/deflectAutoDecom/DeflectAutoDecomStepDestination.kt
Replace all `.` from string keys with `_`. They get translated to `_` anyway in order to be able to access them from Kotlin code so this has no change on the call sites. Keeping the `.` breaks the code generation for CMP resources, this fixes it.
Keep Android-specific code (video player, PDF renderer, date formatting) in androidMain Replace Android-only dependencies with multiplatform alternatives (jetbrains.compose.*)
We've migrated to m3 sheet already anyway
Common interface which defaults to what we always used to do for android anyway Move the date related formatters outside of the `.datepicker` package which were there by accident
Apparently, when the android target is not specified in a project using CMP, it sometimes is possible that when trying to use things that have a different implementation on Android it will instead try to use the jvm option which is not present on Android. Adding the android target means that it now knows to pick the correct actual implementation which works as intended.
Unsure how this bug surfaced itself after the switch to CMP, but keeping the start angle as 0 degrees makes all shapes work as intended.
Fix/mime types
Feature/field error states
# Conflicts: # app/feature/feature-claim-chat/src/commonMain/kotlin/com/hedvig/feature/claim/chat/ui/ClaimChatDestination.kt # app/feature/feature-claim-chat/src/commonMain/kotlin/com/hedvig/feature/claim/chat/ui/ClaimChatUiComponents.kt
…ent-step Feature/layout for current step
convertSimpleFormatToNumberedFormat
change appendPattern
panasetskaya
changed the title
Followed the instructions from https://github.com/DataDog/dd-sdk-android/blob/develop/MIGRATION.MD Make the decision to keep a user ID of `-1` on logged out members to still be able to keep track of `extraInfo` for debugging purposes.
…aging Chore: publish cmp to staging
ai dot with time delay (GEN-4488)
Migrate to DD sdk 3.x (GEN-4663)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this to happen, some more things had to be migrated at the same time
Use HedvigDateTimeFormatterDefaults for all date formatting needs and introduce our own interface which defaults to the java.time impl for android (so impl is unchanged)
Migrate to Coil 3.x
Use CMP resources. Now it's Res.string... instead of R.string...
:design-system-internals
:design-system-api
:core-ui
:core-resources