Skip to content

Make tools widget shortcut configurable#61

Open
TxHawks wants to merge 1 commit into
HazAT:mainfrom
TxHawks:feat/enable-keybinding-overrides
Open

Make tools widget shortcut configurable#61
TxHawks wants to merge 1 commit into
HazAT:mainfrom
TxHawks:feat/enable-keybinding-overrides

Conversation

@TxHawks

@TxHawks TxHawks commented Jul 12, 2026

Copy link
Copy Markdown

This pull request enables users to configure the subagent tools widget shortcut config.json. It:

  • Preserves ctrl+j as the default
  • Reflects the configured shortcut in widget hints
  • Warn and fall back to ctrl+j when the configured shortcut is invalid
  • Documents the new keybindings.toggleToolsWidget option in README.md
  • Adds tests

nertzy added a commit to nertzy/pi-interactive-subagents that referenced this pull request Jul 15, 2026
Pulls in TxHawks' upstream change (HazAT#61, still
open) that makes the subagent tools-widget toggle configurable via
keybindings.toggleToolsWidget in config.json. A local config.json overrides
it to ctrl+shift+x so it stops shadowing pi's built-in tui.input.newLine
(shift+enter | ctrl+j).
@nertzy

nertzy commented Jul 15, 2026

Copy link
Copy Markdown

Thanks for adding this - the config knob is the right primitive. One thing worth deciding before merge: the default stays ctrl+j, which collides with pi's built-in tui.input.newLine (bound to shift+enter and ctrl+j). On current pi that means every user gets an Extension shortcut conflict: 'ctrl+j' is built-in warning on subagent launch, and the extension wins, so ctrl+j stops inserting a newline in subagent panes out of the box.

Since it hits the default path, would you be open to moving the default off ctrl+j too (or skipping registration when the resolved shortcut equals a pi built-in)? That'd make it conflict-free by default and keep the knob for anyone who wants ctrl+j. Happy to send a follow-up commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants