Skip to content

I64 implementation #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

I64 implementation #465

wants to merge 3 commits into from

Conversation

RealyUniqueName
Copy link
Member

Required for HaxeFoundation/haxe#10347
I implemented it as a separate set of functions to avoid intrusion in hashlink internals, which I don't understand yet.

@RealyUniqueName RealyUniqueName mentioned this pull request Aug 9, 2021
Open
Aurel300
Aurel300 reviewed Aug 9, 2021
View reviewed changes
@skial skial mentioned this pull request Aug 11, 2021
Closed
1 task
@ncannasse
Copy link
Member

I think it's better to use directly JIT operations for that. HL already has a native I64 type, exposed through hl.I64
However I haven't implemented the JIT operations on 64 bits integers. The main reason was that support for 32 bits was quite difficult to implement.

I think this could work if could first focus on adding 64 bit JIT support (through hashlink/src/jit.c) , then we can find a way to use such primitives fallback at JIT level for 32 bit support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncannasse ncannasse Awaiting requested review from ncannasse

1 more reviewer

@Aurel300 Aurel300 Aurel300 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RealyUniqueName @ncannasse @Aurel300