Deprecate FlxGraphicSource in favor of FlxGraphicAsset #3469
+25
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Builds are failing due to flixel-ui, whoops! I'll mark this a draft for now until I can look in to it more. |
rifxii
force-pushed
the
deprecate-graphic-source
branch
from
c5be7de to
39a838f
Compare
Final clean-up
rifxii
force-pushed
the
deprecate-graphic-source
branch
from
39a838f to
8fff935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlxGraphicSource from my understanding serves the same purpose as FlxGraphicAsset, so I merged FlxGraphicSource's resolveBitmapData function and BitmapData class support into FlxGraphicAsset, deprecated it, and updated any usage of it inside flixel.
My main issue with FlxGraphicSource is the lack of support for FlxGraphic. When using FlxAtlas, one of the very few classes that support it, having to write
FlxAtlas.addNode(graphic.bitmap);instead ofFlxAtlas.addNode(graphic);feels like an unnecessary workaround.