Skip to content

Conversation

@martijnrusschen
Copy link
Member

Fixes #3673 and #4649

  • When selectsRange is true with showTimeInput, render two time inputs (one for start date, one for end date)
  • Add modifyDateType parameter to handleTimeChange to explicitly specify which date to modify
  • Each time input independently updates its corresponding date
  • Add 7 new tests for showTimeInput with selectsRange functionality

Changes:

  • src/index.tsx: Updated handleTimeChange to accept modifyDateType param
  • src/calendar.tsx: Updated renderInputTimeSection to render two inputs
  • src/test/datepicker_test.test.tsx: Added tests for new functionality

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.23%. Comparing base (a9517e4) to head (ac15422).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6079      +/-   ##
==========================================
+ Coverage   99.14%   99.23%   +0.08%     
==========================================
  Files          30       30              
  Lines        3612     3644      +32     
  Branches     1548     1571      +23     
==========================================
+ Hits         3581     3616      +35     
+ Misses         29       27       -2     
+ Partials        2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martijnrusschen martijnrusschen force-pushed the fix/selectsRange-time-input-issues branch from 5e81443 to 50392ce Compare December 1, 2025 15:35
Fixes #3673 and #4649

- When selectsRange is true with showTimeInput, render two time inputs
  (one for start date, one for end date)
- Add modifyDateType parameter to handleTimeChange to explicitly specify
  which date to modify
- Each time input independently updates its corresponding date
- Add 7 new tests for showTimeInput with selectsRange functionality

Changes:
- src/index.tsx: Updated handleTimeChange to accept modifyDateType param
- src/calendar.tsx: Updated renderInputTimeSection to render two inputs
- src/test/datepicker_test.test.tsx: Added tests for new functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

selectsRange with showTimeInput shows only one time input

2 participants