Brussels | itp-2025-1 | Tam Huynh | Module-Structuring-and-Testing-Data | Coursework sprint 1 #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MustafaBora
reviewed
Dec 12, 2025
| // return the BMI of someone based off their weight and height | ||
| } | ||
| // return the BMI of someone based off their weight and height | ||
| let BMI = weight / (height * height); |
MustafaBora
suggested changes
Dec 12, 2025
MustafaBora
left a comment
MustafaBora
left a comment
There was a problem hiding this comment.
Good in general, couple of changes needed.
| let toPounds = function (str) { | ||
| const penceStringWithoutTrailingP = str.substring( | ||
| 0, | ||
| penceString.length - 1 // take only 399 |
There was a problem hiding this comment.
penceString variable is a variable defined outside, Maybe you meant str? Check this please
| } | ||
| } | ||
| return `${findCharacter} appears ${num} time(s).`; | ||
| } else return 0; |
There was a problem hiding this comment.
a function shouldn't return different types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.