Skip to content

Conversation

@serotonine
Copy link

Learners, PR Template

Self checklist

  • [ x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ x ] My changes meet the requirements of the task
  • [ x ] I have tested my changes
  • [ x ] My changes follow the style guide

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

// Create a variable to store the dir part of the filePath variable
// Create a variable to store the ext part of the variable
// Create a variable to store the directories part of the filePath variable.
// Create a variable to store the extension part of the variable.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcting the questions makes the reader confused

Copy link

@MustafaBora MustafaBora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@@ -1,4 +1,4 @@
const movieLength = 8784; // length of movie in seconds
const movieLength = -8784; // length of movie in seconds

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why minus?

- console.log(["message"], value.toString())
- console.assert(assertion, "message", [optionalParams]);
- - assertion returns a boolean (false / true). If false the message will be displayed in the console.
- - E.g. console.assert(5 < 2, "You are really dumb into mathematics");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants