Skip to content

Conversation

@drdarshanas
Copy link
Collaborator

Removed commented-out requirements for form fields.

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

Removed commented-out requirements for form fields.
@drdarshanas drdarshanas requested review from EL1VAS and aviv82 October 17, 2025 16:34
@aviv82 aviv82 changed the base branch from main to development October 18, 2025 09:47
@talmurshidi talmurshidi changed the title ITP- 2025-1 /Darshana SANGHAVI /Week 2/module -Onboarding ITP- 2025-1 /Darshana SANGHAVI /Week 2/forms-control Nov 9, 2025
@talmurshidi talmurshidi self-requested a review November 9, 2025 09:09
@talmurshidi
Copy link
Member

You have good start, @drdarshanas

What’s Missing / Needs Improvement

  • Use correct branch name features/forms-control
  • Your form doesn’t yet contain real input fields (<input>, <select>, or <button>).
  • You only listed items using <li>, which doesn’t collect user data.
  • Each question must have an associated <label> linked to an input (e.g. for="name").
  • You need to add validation:
    • The name field should be required and at least 2 characters (minlength="2").
    • The email field should use type="email" so the browser can check for valid format.
  • The colour options must be limited to three fixed choices — use radio buttons so only one can be selected.
  • The size options must offer six fixed choices — use a <select> dropdown or another radio group.
  • Add a submit button (<button type="submit">Submit</button>) so the form can be tested.
  • For accessibility and structure, wrap related inputs inside <fieldset> elements with a <legend> title.
  • Keep indentation and spacing consistent to improve readability (see CodeYourFuture Style Guide
    ).

Example Snippet to Guide You

<label for="email">Email:</label>
<input type="email" id="email" name="email" required />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants