ITP-2025-1 | Elena Vasileia | Week 1 | Feature/wireframe

[EL1VAS]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

This is a pull request for the created feature/wireframe branch in the Wireframe of the Module-Onboarding fork. I have changed the index.html, style.css files and added some svg images that I have created and/or downloaded.

Questions/Remarks:

-I didn't manage to change the footer alignment, according to AI I need Javascript for that.
-Also in one of the commits the description is not entirely correct, as I mentioned "I altered the font size of all paragraphs" when actually I only altered the font size of the header paragraph. My intention was to alter all but changed my mind midways 😄
-I struggled to understand the whole pull proccess, as it didn't make sence to me: if all of us make suggestion to alter your original HYF repository and let's say you accept them all when reviewing, how will you keep your repository intact for future use?
-Also I will only now put the tag to review in my issues because I couldn't do it anywhere else. Then I saw slack messages and I think I understand correct
-I tried to find a way to check my webpage as I was making changes especially in CSS but the best way I found is actually code it in VS Code save it and then review it with Live Server. Then copy everything, or just the desired parts back to Github. Is there an easier or more efficient way?
-I love all the extra info to research, but given the fact that we had to squeeze two weeks in one, plus a heavy personal program this week, made it a little chaotic to explore AND be on time for the assignments. I used AI as a tutor to save time, but still I can't say I have explored as thoroughtly as I wanted.
Have a nice weekend !

Ask any questions you have for your reviewer.

[tam-fr]

Nice name :)

[talmurshidi]

Good start, @EL1VAS

What to Fix

Footer Alignment

“I didn't manage to change the footer alignment, according to AI I need JavaScript for that.”

Incorrect. You don’t need JavaScript for a fixed footer — only CSS.

Use this CSS:

footer {
  position: fixed;
  left: 0;
  right: 0;
  bottom: 0;
  text-align: center;
}

Article Structure

Each article should follow the same internal pattern:

<article>
  <img src="..." alt="Descriptive image text" />
  <h2>Article Title</h2>
  <p>Short summary of the topic.</p>
  <a href="..." target="_blank" rel="noopener noreferrer">
    Learn more about [topic]
  </a>
</article>

Footer Content

<footer>
  <p><small>Created by El1VAS — October 2025</small></p>
</footer>

Commit Message Accuracy

“I altered the font size of all paragraphs” (but only changed one)

Keep commit messages accurate and specific:

git commit -m "style: adjust font size of header paragraph"

Understanding Pull Requests

“If all of us make suggestions and you accept them, won’t the original repo be changed?”

No — because:

• You fork the HYF repo.
• You create a branch in your fork.
• You open a Pull Request to the upstream repo.
• Trainers review but don’t merge into main — they simply close or leave the PR after review.
  This keeps the original repo intact while tracking your progress.

Workflow for Previewing Changes

Your workflow (VS Code + Live Server) is excellent.
Here’s the cleanest flow:

# One-time setup
git clone <your-fork-url>
cd <project-folder>
git switch -c feature/wireframe

Then:

• Edit in VS Code.
• Use Live Server to preview instantly.
• Commit small changes often.
• Push and open your PR.
  Avoid copying code back and forth into GitHub — push from local to preserve your Git history.