forked from CodeYourFuture/Module-Data-Groups
-
Notifications
You must be signed in to change notification settings - Fork 9
Brussels | ITP2025 | Elena Vasileia | Week 9 | Sprint 3/quotegenerator #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EL1VAS
wants to merge
68
commits into
HackYourFutureBelgium:main
Choose a base branch
from
EL1VAS:Sprint-3/quotegenerator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Brussels | ITP2025 | Elena Vasileia | Week 9 | Sprint 3/quotegenerator #85
EL1VAS
wants to merge
68
commits into
HackYourFutureBelgium:main
from
EL1VAS:Sprint-3/quotegenerator
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s as I was doing the preparation.
…ependinf weather the box is checked or not
…y quote only without the icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I wrote the css for that project, altered the html and js files. Experimented with importing fonts from Google fonts, with flexboxes and with setInterval in js. I tried to input an icon od quotationmarks in front of quotes, I managed to do it but then when test were failing I removed it as I thought it could be the reason of tests failing. But it wasn't!!! I tried everything, also with AI for hours and hours and still tests fail. Please advise further...
It was challenging to fully get the way of work and actually to create the procces. The logic and theory is there, I do understand what I have to do, but to set everything together was challenging (I was fixing the one, messing with the other kind of way).
Still for some concepts like innerText and textContent, my knowledge its not established as of where to use when.
Questions
Ask any questions you have for your reviewer.