forked from CodeYourFuture/Module-Data-Groups
-
Notifications
You must be signed in to change notification settings - Fork 11
Brussels | ITP2025 | Elena Vasileia | Week 9 | Sprint-3 | Sprint-3/alarm clock #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EL1VAS
wants to merge
32
commits into
HackYourFutureBelgium:main
Choose a base branch
from
EL1VAS:Sprint-3/Alarm-clock
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s as I was doing the preparation.
… passes till 00:00. Added comments
… reset when stop button was pressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I created the rest of the alarm clock functions, altered slightly the HTML file, installed files so jest tests can run (AI helped). I prompted AI as per a previous task to perform tutor role and researched how the setInterval works then applied it in my function. I altered part of the code that was not supposed to be edited, just to reset the background color when alarm was paused (coulldn't leave it orange :)). I tested the page in browser and worked with DOM.
Questions
Ask any questions you have for your reviewer.