Skip to content

10 Update Pre-Course module and HTML-CSS#51

Merged
adamblanchard merged 5 commits into
mainfrom
10-update-pre-course-module
May 6, 2025
Merged

10 Update Pre-Course module and HTML-CSS#51
adamblanchard merged 5 commits into
mainfrom
10-update-pre-course-module

Conversation

@jason-vasilev

@jason-vasilev jason-vasilev commented May 3, 2025

Copy link
Copy Markdown
Contributor

Introduces the following changes:

  1. Fix 404 Pre-course links in HTML-CSS
  2. Language updates as renaming "homework" to "assignment", "lesson" to "session", "class" to "team"
  3. Optimize graphic assets from from 3mb to 300kb by using https://squoosh.app/
  4. Changed Session-exercise-template for Order form exercise to use index.html, styles.css, and removed empty id attributes, to set trainees on common good practices
  5. Added detailed instructions to Order form exercise (The-one-and-only-week1/README.md) based on often-experienced pitfalls. Included link to video introduction to Figma.

Needs discussion:

  1. Are the screenshots in first-assignment-submission.md still the process we want to follow? This is the split where trainees can either push PRs towards repo maintained by HYF, or towards the main branch of their own repo. We had quite some issues with team31 and 32 where we weren't merging their first PRs as they were towards a HYF repo.
  2. Point 9 (previously 8) in first-assignment-submission.md might need changing from "post to Slack team channel" to "post to assignment sheet for this week"

Easy preview

HTML-CSS
Pre-Course

@jason-vasilev jason-vasilev added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels May 3, 2025
@jason-vasilev jason-vasilev self-assigned this May 3, 2025
@jason-vasilev jason-vasilev linked an issue May 3, 2025 that may be closed by this pull request
@jason-vasilev jason-vasilev marked this pull request as ready for review May 3, 2025 20:26
@jason-vasilev jason-vasilev requested a review from a team as a code owner May 3, 2025 20:26
Comment thread courses/Foundation/html-css/The-one-and-only-week1/README.md Outdated
Co-authored-by: Rachel Evans <rachel@rachelevans.org>

@adamblanchard adamblanchard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @jason-vasilev! And for the language updates 🙇

Regarding your two discussion points:
The assignment review process we should be following is now defined in https://github.com/HackYourFuture-CPH/hyf-homework-template.

Regarding html-css assignment (ie. the first submission), @saloumeh-67 and I thought to remove the requirement to submit via github/pr, since the last teams had a lot of challenges regarding submission, which is not the point of this assignment.

I will raise another task, and write our previously planned idea there for feedback. We can make any changes after your PR here is merged, if that's cool with you.

@jason-vasilev

Copy link
Copy Markdown
Contributor Author

I will raise another task, and write our previously planned idea there for feedback. We can make any changes after your PR here is merged, if that's cool with you.

Sounds good to me. Please, merge if there isn't anything that needs changing 🙂

@adamblanchard adamblanchard merged commit 870edf4 into main May 6, 2025
1 check passed
@adamblanchard

Copy link
Copy Markdown
Contributor

p.s. sorry about the HTML-CSS/html-css issue, that was my bad. Thanks for fixing it!

@rvedotrc rvedotrc deleted the 10-update-pre-course-module branch October 15, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Update "pre-course" module

3 participants