Javascript foundation module#50
Merged
Merged
Conversation
marcorichetta
approved these changes
May 2, 2025
rvedotrc
reviewed
May 2, 2025
| | ---------------------------------------------------------------------------- | ----- | | ||
| | [Collaboration via GitHub](../../shared-modules/collaboration-via-github/) | 1 | | ||
| | Frontend JavaScript stuff | ? | | ||
| | [JavaScript Advanced](../../shared-modules/javascript-advanced/) | 4 | |
Contributor
There was a problem hiding this comment.
English has adjectives before nouns (obviously, but I thought it might be worth stating anyway).
hence prefer either "Advanced JavaScript" or "JavaScript (Advanced)", for example.
Contributor
Author
There was a problem hiding this comment.
I'll make another PR and tidy up some module naming with this in mind, thanks!
jason-vasilev
approved these changes
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49
This also includes renaming "homework" to "assignment/s", but in it's own commit. Not 100% sure the best way to go about this huge renaming, but my gut says doing it module by module as we create them is the best way.