Skip to content

Comments

Yana P.#18

Open
YanaP1312 wants to merge 3 commits intoHackYourAssignment:mainfrom
YanaP1312:main
Open

Yana P.#18
YanaP1312 wants to merge 3 commits intoHackYourAssignment:mainfrom
YanaP1312:main

Conversation

@YanaP1312
Copy link

No description provided.

@github-actions

This comment has been minimized.

@mo92othman mo92othman self-assigned this Jan 20, 2026
Copy link

@mo92othman mo92othman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @YanaP1312 ,good work overall, the script follows the assignment well and runs correctly.

I left a couple of small comments about details (folder name casing) to keep in mind.

About the second task: teh GitHub welcome page looks amzing! The GitHub Streak section seems to miss some data, it would be nice to can fix that.

Best of luck on your journey at Hack Your Future.

@@ -1 +1,20 @@
# Write your code here No newline at end of file
echo "Creating project..."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually it is a good practice to include #!/bin/bash or #!/usr/bin/env bash line at the beginning of a shell script file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mo92othman for taking the time to review my work. I got a bit confused about the folder name casing, since the structure in the assignment used lowercase, while step 9 referred to an uppercase version. I’ve now made everything consistent and also added #!/bin/bash at the top as you suggested.
I’ve pushed the updated changes to GitHub, so the pull request now reflects the corrected version.
I also updated my GitHub page, and everything works properly now, including the GitHub Streak section.
Thank you again for your attention and guidance.

echo "Creating project..."
mkdir project
cd project && git init
mkdir -p resources src/database src/profile && touch README.md settings.conf "resources/family picture.jpg" resources/icon.png resources/logo.png src/program.java

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Details matter. The folder created is named resources (lowercase). Using Resources is better to flow the instructions of teh assignemnt.

mkdir project
cd project && git init
mkdir -p resources src/database src/profile && touch README.md settings.conf "resources/family picture.jpg" resources/icon.png resources/logo.png src/program.java
git add . && git commit -m "initial commit"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well 👍 Just a note: you can run thenm using && as you did. And you can also run git add . and git commit as separate commands too.

task-1/setup.sh Outdated
rm "resources/family picture.jpg"
git add . && git commit -m "Add info to README.md"
sleep 3
ls -la Resources

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind the casing here.

mv src/program.java src/program.js
echo 'console.log("JavaScript works!");' > src/program.js
node src/program.js
git add . && git commit -m "Change program.java to program.js"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice descriptive commit message.

@github-actions
Copy link

📝 HackYourFuture auto grade

Assignment Score: 80 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 50
🧪 The auto grade is experimental and still being improved

Test Details
======================= Task 1 =======================
▶️ Running setup.sh...
✅ Successfully executed setup.sh.
✅ Script ran for at least 6 seconds
✅ Path exists: project
✅ Path exists: project/README.md
✅ Path exists: project/settings.conf
✅ Path exists: project/resources
✅ Path exists: project/resources/icon.png
✅ Path exists: project/resources/logo.png
✅ Path exists: project/src
✅ Path exists: project/src/program.js
✅ Path exists: project/src/database
✅ Path exists: project/.git
✅ Path does not exist: project/resources/family picture.jpg
✅ Path does not exist: project/src/profile
✅ Path does not exist: project/src/program.java
✅ File content is correct: project/src/program.js
✅ File content is correct: project/README.md
✅ Output has: "Creating project"
✅ Output has: "Setup project"
✅ Output has: "Setup JavaScript"
✅ Output has: "JavaScript works!"
✅ Output has: "icon.png"
✅ Output has: "All done!"
✅ Found 3 commits
✅ First commit message is "initial commit"

======================= Task 2 =======================
Your GitHub username: YanaP1312
▶️ Downloading profile README from: https://raw.githubusercontent.com/YanaP1312/YanaP1312/main/README.md
❌ Profile does not contain GitHub top languages widget
✅ Profile contains GitHub streaks widget
✅ Profile contains an animated title

======================= Summary =======================
- Task 1 Score: 100%
- Task 2 Score: 33%
Total Score: 80%
Min passing score: 50%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants