Conversation
This comment has been minimized.
This comment has been minimized.
mo92othman
left a comment
There was a problem hiding this comment.
Hi @YanaP1312 ,good work overall, the script follows the assignment well and runs correctly.
I left a couple of small comments about details (folder name casing) to keep in mind.
About the second task: teh GitHub welcome page looks amzing! The GitHub Streak section seems to miss some data, it would be nice to can fix that.
Best of luck on your journey at Hack Your Future.
| @@ -1 +1,20 @@ | |||
| # Write your code here No newline at end of file | |||
| echo "Creating project..." | |||
There was a problem hiding this comment.
Usually it is a good practice to include #!/bin/bash or #!/usr/bin/env bash line at the beginning of a shell script file.
There was a problem hiding this comment.
Thank you @mo92othman for taking the time to review my work. I got a bit confused about the folder name casing, since the structure in the assignment used lowercase, while step 9 referred to an uppercase version. I’ve now made everything consistent and also added #!/bin/bash at the top as you suggested.
I’ve pushed the updated changes to GitHub, so the pull request now reflects the corrected version.
I also updated my GitHub page, and everything works properly now, including the GitHub Streak section.
Thank you again for your attention and guidance.
| echo "Creating project..." | ||
| mkdir project | ||
| cd project && git init | ||
| mkdir -p resources src/database src/profile && touch README.md settings.conf "resources/family picture.jpg" resources/icon.png resources/logo.png src/program.java |
There was a problem hiding this comment.
Details matter. The folder created is named resources (lowercase). Using Resources is better to flow the instructions of teh assignemnt.
| mkdir project | ||
| cd project && git init | ||
| mkdir -p resources src/database src/profile && touch README.md settings.conf "resources/family picture.jpg" resources/icon.png resources/logo.png src/program.java | ||
| git add . && git commit -m "initial commit" |
There was a problem hiding this comment.
This works well 👍 Just a note: you can run thenm using && as you did. And you can also run git add . and git commit as separate commands too.
task-1/setup.sh
Outdated
| rm "resources/family picture.jpg" | ||
| git add . && git commit -m "Add info to README.md" | ||
| sleep 3 | ||
| ls -la Resources |
| mv src/program.java src/program.js | ||
| echo 'console.log("JavaScript works!");' > src/program.js | ||
| node src/program.js | ||
| git add . && git commit -m "Change program.java to program.js" |
📝 HackYourFuture auto gradeAssignment Score: 80 / 100 ✅Status: ✅ Passed Test Details |
No description provided.