Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Hi @hannahwn , thanks for your submission! Great effort! 👍
I left several comments about Bash basics (files vs folders, handling spaces, and directory navigation). Please review those and update the script.
One more note: try to split your work into multiple commits that follow the steps of the assignment, instead of doing many changes in a single commit. This helps keep your Git history clear.
For example, you made your submission in one commit which is final draft , but you could've made th username change in a differnt commit.
About the Task 2 (GitHub) welcome page, Looks good! the "Top Languages Card" is missing, it would be nice to add it.
Overall, good job. Good luck on your journey at HYF.
| touch family picture.jpg icon.png logo.png | ||
| cd .. | ||
| cd src | ||
| touch database profile program.java |
There was a problem hiding this comment.
database and profile should be folders, not files. So in this case we need to use mkdir for directories and touch only for files.
Could you modify it ,please?
task-1/setup.sh
Outdated
| rm family picture.jpg | ||
| cd .. | ||
| git add . | ||
| git commit -m "delete files" |
There was a problem hiding this comment.
The assignment asks to wait 3 seconds between steps using sleep 3, which is missing here.
It is also best practice to write a clear descriptive commit message. So the message coudl be more detailed.
task-1/setup.sh
Outdated
| pwd | ||
| cd resources | ||
| pwd | ||
| ls -a |
There was a problem hiding this comment.
Here you should list the contents of the resources folder, for example with ls resources. Using ls -a lists the current folder instead.
task-1/setup.sh
Outdated
| cd .. | ||
| pwd | ||
| git add . | ||
| git commit -m "model runs" |
There was a problem hiding this comment.
Same about the commit message clarity here.
task-2/github-username.txt
Outdated
| @@ -1 +1 @@ | |||
| <paste here your github username> No newline at end of file | |||
| <paste here your github username>hannahwn | |||
There was a problem hiding this comment.
Here, you could remove the placeholder text and leave only your GitHub username. Could you modify it please?
There was a problem hiding this comment.
It looks like you deleted the file itself in here :) That's not what we wanted to do, right?
📝 HackYourFuture auto gradeAssignment Score: 40 / 100 ❌Status: ❌ Not passed Test Details |
week 1 assignment done