Skip to content

Comments

HannahN#14

Open
hannahwn wants to merge 16 commits intoHackYourAssignment:mainfrom
hannahwn:main
Open

HannahN#14
hannahwn wants to merge 16 commits intoHackYourAssignment:mainfrom
hannahwn:main

Conversation

@hannahwn
Copy link

week 1 assignment done

@github-actions

This comment has been minimized.

Copy link

@mo92othman mo92othman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hannahwn , thanks for your submission! Great effort! 👍

I left several comments about Bash basics (files vs folders, handling spaces, and directory navigation). Please review those and update the script.

One more note: try to split your work into multiple commits that follow the steps of the assignment, instead of doing many changes in a single commit. This helps keep your Git history clear.

For example, you made your submission in one commit which is final draft , but you could've made th username change in a differnt commit.

About the Task 2 (GitHub) welcome page, Looks good! the "Top Languages Card" is missing, it would be nice to add it.


Overall, good job. Good luck on your journey at HYF.

touch family picture.jpg icon.png logo.png
cd ..
cd src
touch database profile program.java

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

database and profile should be folders, not files. So in this case we need to use mkdir for directories and touch only for files.

Could you modify it ,please?

task-1/setup.sh Outdated
rm family picture.jpg
cd ..
git add .
git commit -m "delete files"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assignment asks to wait 3 seconds between steps using sleep 3, which is missing here.

It is also best practice to write a clear descriptive commit message. So the message coudl be more detailed.

task-1/setup.sh Outdated
pwd
cd resources
pwd
ls -a

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you should list the contents of the resources folder, for example with ls resources. Using ls -a lists the current folder instead.

task-1/setup.sh Outdated
cd ..
pwd
git add .
git commit -m "model runs"
Copy link

@mo92othman mo92othman Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same about the commit message clarity here.

@@ -1 +1 @@
<paste here your github username> No newline at end of file
<paste here your github username>hannahwn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, you could remove the placeholder text and leave only your GitHub username. Could you modify it please?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you deleted the file itself in here :) That's not what we wanted to do, right?

@mo92othman mo92othman self-assigned this Jan 20, 2026
@github-actions
Copy link

📝 HackYourFuture auto grade

Assignment Score: 40 / 100 ❌

Status: ❌ Not passed
Minimum score to pass: 50
🧪 The auto grade is experimental and still being improved

Test Details
======================= Task 1 =======================
▶️ Running setup.sh...
✅ Successfully executed setup.sh.
❌ Script ran for less than 6 seconds (3.06s)
✅ Path exists: project
✅ Path exists: project/README.md
✅ Path exists: project/settings.conf
✅ Path exists: project/resources
❌ Path does not exist: project/resources/icon.png
❌ Path does not exist: project/resources/logo.png
✅ Path exists: project/src
❌ Path does not exist: project/src/program.js
❌ Path does not exist: project/src/database
✅ Path exists: project/.git
✅ Path does not exist: project/resources/family picture.jpg
✅ Path does not exist: project/src/profile
✅ Path does not exist: project/src/program.java
❌ Error reading file: project/src/program.js
❌ File content does not match: project/README.md
Expected: "Welcome to my project"
Found:    ""
✅ Output has: "Creating project"
✅ Output has: "Setup project"
✅ Output has: "Setup JavaScript"
✅ Output has: "JavaScript works!"
❌ Output does not have: "icon.png"
✅ Output has: "All done!"
❌ Error checking git commits: Command failed: git rev-list --count HEAD
fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'


======================= Task 2 =======================
Your GitHub username: hannahwn
▶️ Downloading profile README from: https://raw.githubusercontent.com/hannahwn/hannahwn/main/README.md
❌ Profile does not contain GitHub top languages widget
✅ Profile contains GitHub streaks widget
✅ Profile contains an animated title

======================= Summary =======================
- Task 1 Score: 43%
- Task 2 Score: 33%
Total Score: 40%
Min passing score: 50%

@hannahwn hannahwn marked this pull request as draft January 25, 2026 15:20
@hannahwn hannahwn marked this pull request as ready for review January 27, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants