Fix the fusedsdpa with sliding window alignment issue #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libinta
requested review from
afierka-intel,
jikunshang,
kzawora-intel,
madamczyk-intel,
mgawarkiewicz-intel,
michalkuligowski,
mswiniarsk,
tzielinski-habana and
xuechendi
as code owners
madamczyk-intel
requested changes
Jul 18, 2025
Comment on lines
98
to
+101
| if found_bucket is None: | ||
| block_size = self.slice_size if self.use_window_sdpa else self.block_size | ||
| new_batch_size = 2 ** math.ceil(math.log2(batch_size)) | ||
| new_seq_len = math.ceil(seq_len / self.block_size) * self.block_size | ||
| new_seq_len = math.ceil(seq_len / block_size) * block_size |
Contributor
There was a problem hiding this comment.
This is hacky and doesn't really fix the real problem why that bucket hasn't been found.
You can try to change block_size to be a multiple of 1k if that's a hard requirement from FSDPA
| padding_side ='left' | ||
| args.append(window_size) | ||
|
|
||
| args = [query, key, value, attn_bias, 0.0, is_causal, |
Contributor
There was a problem hiding this comment.
Is this change related to missing bucket? I think you could extract it into another PR so we could merge if not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.