Skip to content

Add max_pixels option. #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wenbinc-Bin wants to merge 2 commits into
base: aice/v1.22.0
Choose a base branch
from
Open

Add max_pixels option. #2094

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b9daa0
Add max_pixels option.
wenbinc-Bin Oct 28, 2025
4a27c63
Reuse -e option to set --mm-processor-kwargs
wenbinc-Bin Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/start_gaudi_vllm_server.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ python3 -m vllm.entrypoints.openai.api_server \
--trust-remote-code \
--seed 2025 \
--distributed_executor_backend "${dist_backend}" \
--mm_processor_kwargs "max_pixels=1003520" \
Copy link

@czhu15 czhu15 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this value be configurable by users and set 1003520 as default value?

Copy link
Author

@wenbinc-Bin wenbinc-Bin Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I change it to configurable, what option flag do you suggest I use?

Copy link

@czhu15 czhu15 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I change it to configurable, what option flag do you suggest I use?

how about just reuse -e
cc @yangulei

Copy link
Author

@wenbinc-Bin wenbinc-Bin Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I update the PR and try to reuse -e option to set --mm-processor-kwargs.
It is troublesome to process "max_pixles" alone.

Copy link

@yangulei yangulei Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to pass --mm_processor_kwargs "max_pixels=1003520" to the vllm server, just pass -e "--mm_processor_kwargs max_pixels=1003520" to the start_gaudi_vllm_server.sh. We don't need to change the code.

Copy link
Author

@wenbinc-Bin wenbinc-Bin Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should better set a default value in script because user may doesn't know this options is needed.

Copy link
Author

@wenbinc-Bin wenbinc-Bin Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use -e opton, but with a default value for mm-processor-kwargs. How about this implementation?

"${extra_params[@]}")

echo "Start a vLLM server for ${model_name} on Gaudi $DEVICE_NAME with command:" |& tee -a "${log_file}"
Expand Down