Skip to content

Allow region mask to have name of None #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psavery merged 1 commit into from
Mar 3, 2026
Merged

Allow region mask to have name of None #1976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hexrdgui/masking/mask_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def deserialize(cls, data: dict[str, Any]) -> 'Mask':
class RegionMask(Mask):
def __init__(
self,
name: str = '',
name: str | None = None,
mtype: str = '',
visible: bool = True,
show_border: bool = False,
Expand Down Expand Up @@ -422,7 +422,7 @@ def add_mask(
new_mask = ThresholdMask(name, mtype, visible)
else:
mode = None if mtype == MaskType.pinhole else self.view_mode
new_mask = RegionMask(name or '', mtype, visible, mode=mode)
new_mask = RegionMask(name, mtype, visible, mode=mode)
new_mask.data = data
assert new_mask.name is not None
self.masks[new_mask.name] = new_mask
Expand Down
Loading