Ensure all nan-slice warnings are caught#1941
Merged
Conversation
Member
|
issue still persists on Mac. However, the issue goes away when the |
Collaborator
Author
|
Please let me know if this issue is now gone after all of the latest updates. You can try both with this branch and without this branch. If it still persists... I'll look into it more. |
Member
|
Still persisting, unfortunately. |
saransh13
force-pushed
the
catch-nan-slice-warnings
branch
from
0336f0f to
774e574
Compare
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
psavery
force-pushed
the
catch-nan-slice-warnings
branch
from
774e574 to
43c16a8
Compare
Collaborator
Author
|
I'm hopeful this fix should work. Let me know if it doesn't. |
saransh13
approved these changes
Feb 25, 2026
Member
saransh13
left a comment
saransh13
left a comment
There was a problem hiding this comment.
most recent change fixed the issue. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were not always being caught with the previous setup, but this catches them all.