Open
Conversation
Closed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #891 +/- ##
==========================================
+ Coverage 69.41% 70.69% +1.27%
==========================================
Files 148 142 -6
Lines 22590 22058 -532
==========================================
- Hits 15680 15593 -87
+ Misses 6910 6465 -445 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
psavery
reviewed
Feb 13, 2026
hexrd/core/transforms/xfcapi.py
Outdated
| q2 = np.ascontiguousarray(q2.flatten()) | ||
| # C module expects quaternions in row major, numpy code in column major. | ||
| qsym = np.ascontiguousarray(qsym.T) | ||
| return transforms_c_api.quat_distance(q1, q2, qsym) No newline at end of file |
Collaborator
There was a problem hiding this comment.
I'm assuming most of this file was just copied over from old files like xf_new_capi.py. I did a brief skim over it but I'm assuming it's fine.
psavery
approved these changes
Feb 13, 2026
Collaborator
psavery
left a comment
There was a problem hiding this comment.
LGTM
The corresponding branch in the GUI (HEXRD/hexrdgui#1964) seems to be working well also.
We may have a discussion with users before merging, since this will break code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes a lot of unused and dead code from the transforms module of HEXRD. We aniticpate that this may affect users who have very old scripts (5 years or more) or others who have used the
xforold_xfcapicomponents of the library. As this code has not been supported in many years, it is time for this code to be removed from the library. We will support the transition to the newer code as needed, on a case-by-case basis.Some documentation about transitioning from the
old_xfcapicode can be found in the Wiki:https://github.com/HEXRD/hexrd/wiki/old_xfcapi-Conversion-Guide
Affected Workflows
Users who have scripts which use the
old_xfcapiorxfcomponents of HEXRD's transforms module will need to move off of this and into the new API, using the conversion guide above.Documentation Changes
Documentation regarding transition has been written, and uploaded into the Github Wiki. Documentation covering the removed code has been deleted.