Open
Conversation
psavery
reviewed
Feb 6, 2026
| if cresult: | ||
| print("test passed") | ||
| else: | ||
| print("test failed") |
Collaborator
There was a problem hiding this comment.
If we're keeping this __main__ section, isn't this final printing the most important part of it? Otherwise, if you ran it, you wouldn't know if it passed or failed.
psavery
reviewed
Feb 6, 2026
| else: | ||
| self.fid = open(filename, 'w') | ||
| print(self._header, file=self.fid) | ||
| logger.info(self._header, file=self.fid) |
Collaborator
There was a problem hiding this comment.
Maybe it's better to just write to the file instead? Like:
self.fid.write(self._header)I think using the logger would add extra stuff to the file contents. It looks like the print before was just intended to write to the file. Same for the other ones in this class.
Collaborator
There was a problem hiding this comment.
Maybe using the print() statement before implicitly added a '\n' after each call too, so you might need to add + '\n' to the writes.
psavery
reviewed
Feb 6, 2026
Co-authored-by: Patrick Avery <patrick.avery@kitware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #350
Overview
This PR converts all useful print statements into logger statements, and removes the rest.
Affected Workflows
No workflows are affected by this PR.
Documentation Changes
No documentation changes are required for this PR.