Conversation
|
Ah thanks for looking into that! I will check that it solves the issues I have had |
|
I merged it in #25 and it completely fixed the python version issues I was experiencing :) When I run pytest locally I still get a couple of failures: ===================================================================================================== short test summary info =====================================================================================================
FAILED wmin/tests/test_fit.py::test_bayesian_fits[test_fit_wmin_bayes_dis_L0.yaml] - AssertionError: b''
FAILED wmin/tests/test_fit.py::test_bayesian_fits[test_fit_wmin_bayes_had_L0.yaml] - AssertionError: b''
============================================================================================ 2 failed, 18 passed in 164.62s (0:02:44) =============================================================================================
Thanks for using LHAPDF 6.5.5. Please make sure to cite the paper:
Eur.Phys.J. C75 (2015) 3, 132 (http://arxiv.org/abs/1412.7420)But it does not fail on github. I assume this is because the byte-by-byte comparison may vary from machine to machine, right? |
ElieHammou
left a comment
There was a problem hiding this comment.
Looks good to me and it fixes the previously witnessed issues
No I have the same problem and I think it's related to the fact that for some reason we have different versions of packages locally with respect to github and the random seed behaves differently... this is the sign that the tests will fail in the future, that particular one relies on something that should not be there... In any case, fort he moment we are fine and I will merge. |
This PR removes python 3.11 from the tests, allowing for more recent versions of python needed from the packages we are using.