Open
Conversation
babeuloula
suggested changes
Mar 3, 2022
Comment on lines
+19
to
+30
| /** | ||
| * @var TriggerConfigurationInterface[] | ||
| */ | ||
| private iterable $configurationList; | ||
|
|
||
| /** | ||
| * @param TriggerConfigurationInterface[] $configurationList | ||
| */ | ||
| public function __construct(iterable $configurationList) | ||
| { | ||
| $this->configurationList = $configurationList; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| /** | |
| * @var TriggerConfigurationInterface[] | |
| */ | |
| private iterable $configurationList; | |
| /** | |
| * @param TriggerConfigurationInterface[] $configurationList | |
| */ | |
| public function __construct(iterable $configurationList) | |
| { | |
| $this->configurationList = $configurationList; | |
| } | |
| /** | |
| * @param TriggerConfigurationInterface[] $configurationList | |
| */ | |
| public function __construct(private iterable $configurationList) | |
| { | |
| } |
Comment on lines
+12
to
+42
| private bool $enabled; | ||
| private int $failureTriggeredAt; | ||
| private int $successTriggeredAt; | ||
| private ?string $failureFrom; | ||
| private ?string $successFrom; | ||
| private ?string $failureTo; | ||
| private ?string $successTo; | ||
| private string $failureSubject; | ||
| private string $successSubject; | ||
|
|
||
| public function __construct( | ||
| bool $enabled, | ||
| int $failureTriggeredAt, | ||
| int $successTriggeredAt, | ||
| string $failureSubject, | ||
| string $successSubject, | ||
| ?string $failureFrom = null, | ||
| ?string $successFrom = null, | ||
| ?string $failureTo = null, | ||
| ?string $successTo = null | ||
| ) { | ||
| $this->enabled = $enabled; | ||
| $this->failureTriggeredAt = $failureTriggeredAt; | ||
| $this->successTriggeredAt = $successTriggeredAt; | ||
| $this->failureFrom = $failureFrom; | ||
| $this->successFrom = $successFrom; | ||
| $this->failureTo = $failureTo; | ||
| $this->successTo = $successTo; | ||
| $this->failureSubject = $failureSubject; | ||
| $this->successSubject = $successSubject; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| private bool $enabled; | |
| private int $failureTriggeredAt; | |
| private int $successTriggeredAt; | |
| private ?string $failureFrom; | |
| private ?string $successFrom; | |
| private ?string $failureTo; | |
| private ?string $successTo; | |
| private string $failureSubject; | |
| private string $successSubject; | |
| public function __construct( | |
| bool $enabled, | |
| int $failureTriggeredAt, | |
| int $successTriggeredAt, | |
| string $failureSubject, | |
| string $successSubject, | |
| ?string $failureFrom = null, | |
| ?string $successFrom = null, | |
| ?string $failureTo = null, | |
| ?string $successTo = null | |
| ) { | |
| $this->enabled = $enabled; | |
| $this->failureTriggeredAt = $failureTriggeredAt; | |
| $this->successTriggeredAt = $successTriggeredAt; | |
| $this->failureFrom = $failureFrom; | |
| $this->successFrom = $successFrom; | |
| $this->failureTo = $failureTo; | |
| $this->successTo = $successTo; | |
| $this->failureSubject = $failureSubject; | |
| $this->successSubject = $successSubject; | |
| } | |
| public function __construct( | |
| private bool $enabled, | |
| private int $failureTriggeredAt, | |
| private int $successTriggeredAt, | |
| private string $failureSubject, | |
| private string $successSubject, | |
| private ?string $failureFrom = null, | |
| private ?string $successFrom = null, | |
| private ?string $failureTo = null, | |
| private ?string $successTo = null | |
| ) { | |
| } |
Comment on lines
+26
to
+40
| private TaskListInterface $failedTasksList; | ||
| private TaskListInterface $succeedTasksList; | ||
| private ?MailerInterface $mailer; | ||
| private EmailTriggerConfiguration $emailTriggerConfiguration; | ||
|
|
||
| public function __construct( | ||
| EmailTriggerConfiguration $emailTriggerConfiguration, | ||
| ?MailerInterface $mailer = null | ||
| ) { | ||
| $this->emailTriggerConfiguration = $emailTriggerConfiguration; | ||
| $this->mailer = $mailer; | ||
|
|
||
| $this->failedTasksList = new TaskList(); | ||
| $this->succeedTasksList = new TaskList(); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| private TaskListInterface $failedTasksList; | |
| private TaskListInterface $succeedTasksList; | |
| private ?MailerInterface $mailer; | |
| private EmailTriggerConfiguration $emailTriggerConfiguration; | |
| public function __construct( | |
| EmailTriggerConfiguration $emailTriggerConfiguration, | |
| ?MailerInterface $mailer = null | |
| ) { | |
| $this->emailTriggerConfiguration = $emailTriggerConfiguration; | |
| $this->mailer = $mailer; | |
| $this->failedTasksList = new TaskList(); | |
| $this->succeedTasksList = new TaskList(); | |
| } | |
| private TaskListInterface $failedTasksList; | |
| private TaskListInterface $succeedTasksList; | |
| public function __construct( | |
| private EmailTriggerConfiguration $emailTriggerConfiguration, | |
| private ?MailerInterface $mailer = null | |
| ) { | |
| $this->failedTasksList = new TaskList(); | |
| $this->succeedTasksList = new TaskList(); | |
| } |
Comment on lines
+21
to
+36
| private EventDispatcherInterface $eventDispatcher; | ||
| private LoggerInterface $logger; | ||
| private TriggerConfigurationRegistryInterface $triggerConfigurationRegistry; | ||
| private ?MailerInterface $mailer; | ||
|
|
||
| public function __construct( | ||
| EventDispatcherInterface $eventDispatcher, | ||
| TriggerConfigurationRegistryInterface $triggerConfigurationRegistry, | ||
| ?LoggerInterface $logger = null, | ||
| ?MailerInterface $mailer = null | ||
| ) { | ||
| $this->eventDispatcher = $eventDispatcher; | ||
| $this->triggerConfigurationRegistry = $triggerConfigurationRegistry; | ||
| $this->logger = $logger ?? new NullLogger(); | ||
|
|
||
| $this->mailer = $mailer; |
Contributor
There was a problem hiding this comment.
Suggested change
| private EventDispatcherInterface $eventDispatcher; | |
| private LoggerInterface $logger; | |
| private TriggerConfigurationRegistryInterface $triggerConfigurationRegistry; | |
| private ?MailerInterface $mailer; | |
| public function __construct( | |
| EventDispatcherInterface $eventDispatcher, | |
| TriggerConfigurationRegistryInterface $triggerConfigurationRegistry, | |
| ?LoggerInterface $logger = null, | |
| ?MailerInterface $mailer = null | |
| ) { | |
| $this->eventDispatcher = $eventDispatcher; | |
| $this->triggerConfigurationRegistry = $triggerConfigurationRegistry; | |
| $this->logger = $logger ?? new NullLogger(); | |
| $this->mailer = $mailer; | |
| public function __construct( | |
| private EventDispatcherInterface $eventDispatcher, | |
| private TriggerConfigurationRegistryInterface $triggerConfigurationRegistry, | |
| ?LoggerInterface $logger = null, | |
| private ?MailerInterface $mailer = null | |
| ) { | |
| $this->logger = $logger ?? new NullLogger(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.