Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.x #105 +/- ##
==========================================
+ Coverage 86.97% 87.05% +0.08%
==========================================
Files 20 20
Lines 1888 1900 +12
==========================================
+ Hits 1642 1654 +12
Misses 246 246 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leoguignard
requested changes
Feb 26, 2026
Member
leoguignard
left a comment
leoguignard
left a comment
There was a problem hiding this comment.
small typo and precision on the description
Comment on lines
+762
to
+765
| with_leaves : bool, optional | ||
| Include the chains that contain leaves in the histogram, by default False | ||
| with_roots : bool, optional | ||
| Include the chains that contain roots in the histogram, by default False |
Member
There was a problem hiding this comment.
They are not optional, they have default values, there is a difference
| with_roots : bool, optional | ||
| Include the chains that contain roots in the histogram, by default False | ||
| bins : int, optional | ||
| Bins of tghe histogram, if none they are set automatically, by default None |
Member
|
Can you fix the conflicts to enable the merge please? |
leoguignard
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added easy access to the chain histogram