✨ Enhances the jukebox CLI with Typer#254
Open
Gudsfile wants to merge 3 commits into
Open
Conversation
Gudsfile
force-pushed
the
feature/jukebox-as-typer-cli
branch
from
a4b3a46 to
ddf61ab
Compare
Gudsfile
force-pushed
the
refactor/phase-4-settings-controller
branch
from
a2ba362 to
2667dc6
Compare
Gudsfile
force-pushed
the
feature/jukebox-as-typer-cli
branch
from
ddf61ab to
4a9f5be
Compare
Gudsfile
force-pushed
the
refactor/phase-4-settings-controller
branch
from
2667dc6 to
d9ef311
Compare
Gudsfile
force-pushed
the
feature/jukebox-as-typer-cli
branch
from
4a9f5be to
936e069
Compare
Gudsfile
force-pushed
the
refactor/phase-4-settings-controller
branch
from
d9ef311 to
2e9f15e
Compare
Gudsfile
force-pushed
the
feature/jukebox-as-typer-cli
branch
2 times, most recently
from
9a51055 to
7ab6c4f
Compare
Gudsfile
force-pushed
the
refactor/phase-4-settings-controller
branch
from
2e9f15e to
ff6bc8c
Compare
Gudsfile
force-pushed
the
feature/jukebox-as-typer-cli
branch
8 times, most recently
from
83b3ef7 to
51587b1
Compare
Owner
Author
|
Gudsfile
force-pushed
the
refactor/phase-4-settings-controller
branch
from
ff6bc8c to
484d589
Compare
Gudsfile
force-pushed
the
feature/jukebox-as-typer-cli
branch
from
51587b1 to
76b985b
Compare
Collaborator
|
This is looking great!! |
msgerbush
approved these changes
May 13, 2026
msgerbush
reviewed
May 13, 2026
| app = typer.Typer(help="Play music on speakers using NFC tags", invoke_without_command=True) | ||
|
|
||
|
|
||
| @app.callback() |
Collaborator
There was a problem hiding this comment.
I think this should be a command, rather than a callback? I believe callback is only used when you're expecting subcommands, and the main CLI application is just a wrapper for those commands. https://typer.tiangolo.com/tutorial/commands/callback/
Collaborator
There was a problem hiding this comment.
If you look at the help text, you'll see it's outputting Usage: jukebox [OPTIONS] COMMAND [ARGS]... even though jukebox has no subcommands
msgerbush
requested changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #234
Summary
Mirrors the jukebox-admin CLI with Typer (introduced in #167).
adapters/inbound/config.pyand rewriteapp.pybuild_settings_serviceandbuild_runtime_resolverout ofapp.pyintodi_container.py, where all wiring belongssys.argvpatching totyper.testing.CliRunner; add coverage for bad options, unknown subcommands, and CLI-vs-persisted-settings precedenceTest plan
uv run pytestall tests passuv run jukebox --helpoptions render correctlyuv run jukebox --versionversion printed and exitsuv run jukebox --sonos-host 1.2.3.4 --sonos-name fooexits with mutual exclusion erroruv run jukebox --pause-duration totoexits with not valid type error