♻️ Remove UIController delegation wrappers#250
Merged
Conversation
msgerbush
approved these changes
May 7, 2026
Collaborator
msgerbush
left a comment
msgerbush
left a comment
There was a problem hiding this comment.
Looks good. Thanks for making it easy to review 👍
Routes now call library_pages, settings_pages, and sonos_pages directly. Wrapper-focused tests moved to tests/…/ui_pages/test_library_page_builder.py.
msgerbush
force-pushed
the
refactor/phase-2-uicontroller-cleanup
branch
from
642c492 to
959d198
Compare
msgerbush
added a commit
that referenced
this pull request
May 7, 2026
Follows #250 ## Summary - Extract all page rendering assertions from `test_ui_controller.py` into dedicated page builder test files - `test_ui_controller.py` now only tests HTTP routing and handler behaviour - Settings, Sonos, and library page builder tests are now fully isolated in `ui_pages/` ## Test plan - `uv run --extra ui pytest`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #220
Summary
UIControllerthat did nothing but delegate toLibraryUIPageBuilder,SettingsUIPageBuilder, andSonosUIPageBuilder(were useful as a transition)test_library_page_builder.pywalk_componentstest helper into a shared conftest fixture__anext__()workaround with theanext()builtin (since we're using Python 3.11+)Extracting equivalent dedicated tests for settings and sonos page builders is a follow-up item (those tests were not directly affected by removing the controller wrappers).
Test plan
uv run --extra ui pytest)