Fix: Support dynamic locale switching (Fixes #85)#101
Open
robotex82 wants to merge 1 commit intoGuavaCZ:mainfrom
Open
Fix: Support dynamic locale switching (Fixes #85)#101robotex82 wants to merge 1 commit intoGuavaCZ:mainfrom
robotex82 wants to merge 1 commit intoGuavaCZ:mainfrom
Conversation
ea48fdc to
e5a32a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Support dynamic locale switching (Fixes #85)
Description
This PR fixes an issue where documentation content and the sidebar would stick to the boot-time locale (typically from
.env), ignoring runtime locale changes (e.g., via middleware).Changes
FlatfileNode::getRows()to scan and load documentation for all available locales found in the docs directory, rather than just the current app locale.de.welcome) to prevent ID collisions in the Sushi cache.App::getLocale().FlatfileNode::all(), used by the sidebar navigation builder, only returns items for the current user's language.Verification
Verified that switching the user's locale at runtime correctly updates both the documentation content and the sidebar navigation structure.