fix: context info for event actions being null#141
fix: context info for event actions being null#141rajabilal555 wants to merge 1 commit intoGuavaCZ:mainfrom
Conversation
|
Can confirm this fixes the issue - it needs to be accessible for livewire. |
|
Thanks for the PR! I'm not sure I like allowing the raw data to be accessed though. Can you please refactor the That way you should be able to access the resource using the intended API. |
|
I was looking at it earlier because the protected to public fix felt instinctively off, so wondered if there was another way. But the code doesn't actually access the property anywhere directly, it's only when livewire is re-hydrating the component and filling it from the front end values. With it protected the values get lost between requests, breaking all the context menu functions. I don't understand the lifecycle enough to see how to avoid it storing the data in the front end. Possibly it could have the [#[Locked]] attribute to imply it's public only because of livewire reasons, but all the data is from the front end anyway and it doesn't do anything to stop back end changes so I don't know if it really improves the situation any. |
|
Hi, thanks @paulhennell that could work. However I can still not replicate any of the issues, can anyone please create a small repository and replicate the issue there, so I can look into it in more detail? Thanks. |
fixes: #140