fix[next-dace]: Map stride of local dimension in nested SDFG#2593
fix[next-dace]: Map stride of local dimension in nested SDFG#2593edopao wants to merge 10 commits intoGridTools:mainfrom
Conversation
philip-paul-mueller
left a comment
There was a problem hiding this comment.
I am not fully happy with this change because it has potentially big implication for the IfMover and the condition fuser (which will stop working, since it can no longer identifying which If-Blocks can be moved together.
Because of these implication we must absolutely make sure to also run MuPhys, because, it will be very much impacted by these changes.
I am actually not sure if the data locality is actually improved, because in the almost everything has a restrict keyword, so the compiler should be smart enough tio figuring that out.
But this is just my concern or have you different opinions @iomaganaris
I see your point, makes sense. This change is not part of the bugfix, so I could revert it. |
This PR contains 3 kinds of changes:
Addition of connectivities. This is needed to support the pattern with
can_derefexpressions (not part of this PR, see feat[next-dace]: Lowering mixed-GTIR to SDFG #2467). After GTIR transformations, which unroll the neighbors loops, a common pattern in grids with skip values isif(can_deref(a, V2E), deref(a(V2E)) + 2, 0).Renaming of function parameters.
TODO: