You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR re-enables a warning which was hit in ICON4Py by the dace backend, because we forced the backend to always compute fields everywhere, as a workaround for an issue in the dace backend, also when gt4py can infer the minimal domain at compile time.
The issue in the dace backed was caused by a bug in de-referencing a field computed on the minimal domain. Tested in icon4py PR C2SM/icon4py#1190
edopao
changed the title
fix[next]: Eenable warning for max domain on compile-time domain
fix[next]: Enable warning for max domain on field operators with compile-time domain
Apr 9, 2026
The reason will be displayed to describe this comment to others. Learn more.
Can we add an integration test? test_unstructured_shift called with a field of non-zero domain start / origin should trigger this too right? Maybe we should also rename the PR since the main part is the fix not really the reintroduction of the warning.
Can we add an integration test? test_unstructured_shift called with a field of non-zero domain start / origin should trigger this too right? Maybe we should also rename the PR since the main part is the fix not really the reintroduction of the warning.
Good point. I have added two test cases. One is a variant of test_unstructured_shift, as you suggested, however this case was already working. The other one is testing neighbor_sum with a field of non-zero origin, and this was failing. Anyway, both are relevant: the first covers the lowering of unstructured shift operator and the second reduce+neighbors builtins.
edopao
changed the title
fix[next]: Enable warning for max domain on field operators with compile-time domain
fix[next-dace]: Fix SDFG lowering of neighbors-reduce on field with non-zero origin
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edopao
changed the title
This PR re-enables a warning which was hit in ICON4Py by the dace backend, because we forced the backend to always compute fields everywhere, as a workaround for an issue in the dace backend, also when gt4py can infer the minimal domain at compile time.
The issue in the dace backed was caused by a bug in de-referencing a field computed on the minimal domain. Tested in icon4py PR C2SM/icon4py#1190