Open
Conversation
GrettaSmith
force-pushed
the
add-database
branch
from
c8e7b27 to
6b115df
Compare
felixoff
reviewed
Apr 11, 2023
| public class Film { | ||
|
|
||
| Integer id; | ||
| private Integer id; |
There was a problem hiding this comment.
Вместо множественных private лучше использовать FieldDefaults
| @@ -16,19 +14,20 @@ | |||
| @Builder | |||
| @AllArgsConstructor | |||
| @ValidateOnExecution | |||
There was a problem hiding this comment.
Валидировать лучше в слое контроллеров
| Film film = filmStorage.getFilmById(id); | ||
| if (!film.getUserLikes().contains(userId)) { | ||
| throw new NotFoundException("Film not found!"); | ||
| throw new NotFoundException("User not found!"); |
There was a problem hiding this comment.
Указывай id в комментариях пользователю
| protected final Set<Film> filmsRating = new TreeSet<>(likesComparator); | ||
|
|
||
| private final HashMap<Integer, Film> filmsList = new HashMap<>(); | ||
| private int id = 0; |
There was a problem hiding this comment.
Не обязательно инициализироаать примитивный дефолтными значениями
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.