Skip to content

Small number of fixes#963

Merged
GregHib merged 7 commits intomainfrom
fixes
Apr 28, 2026
Merged

Small number of fixes#963
GregHib merged 7 commits intomainfrom
fixes

Conversation

@GregHib
Copy link
Copy Markdown
Owner

@GregHib GregHib commented Apr 28, 2026

  • Npcs not retaliating against other npcs
  • Telegrab
  • Default game loop and logging settings
  • Not restoring run energy on death
  • Add support for splitting player dialogues over 4 lines long

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.70%. Comparing base (6f69c4b) to head (b3f4fe8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tent/entity/player/dialogue/type/PlayerDialogue.kt 50.00% 0 Missing and 2 partials ⚠️
...gin/protocol/decode/InterfaceOnFloorItemDecoder.kt 33.33% 1 Missing and 1 partial ⚠️
...content/skill/magic/book/modern/TelekineticGrab.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
.../main/kotlin/world/gregs/voidps/engine/GameLoop.kt 3.12% <ø> (+0.26%) ⬆️
...rc/main/kotlin/content/entity/death/PlayerDeath.kt 54.28% <100.00%> (-0.59%) ⬇️
...rc/main/kotlin/content/entity/npc/combat/Attack.kt 52.20% <100.00%> (-1.14%) ⬇️
...content/skill/magic/book/modern/TelekineticGrab.kt 58.97% <0.00%> (-4.86%) ⬇️
...tent/entity/player/dialogue/type/PlayerDialogue.kt 90.47% <50.00%> (-9.53%) ⬇️
...gin/protocol/decode/InterfaceOnFloorItemDecoder.kt 88.88% <33.33%> (-11.12%) ⬇️

... and 1339 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #963      +/-   ##
============================================
- Coverage     38.16%   37.70%   -0.47%     
  Complexity     8132     8132              
============================================
  Files          1682     1680       -2     
  Lines         76410    67365    -9045     
  Branches      16822    16825       +3     
============================================
- Hits          29163    25397    -3766     
+ Misses        41569    36286    -5283     
- Partials       5678     5682       +4     
Components Coverage Δ
Content 35.75% <57.14%> (-0.23%) ⬇️
Engine 45.24% <ø> (-1.48%) ⬇️
Network 60.18% <33.33%> (-0.70%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit 5402313 into main Apr 28, 2026
5 checks passed
@GregHib GregHib deleted the fixes branch April 28, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant