Getting started instructions, proposal for Black formatting#34
Open
spra85 wants to merge 3 commits intoGreenBuildingRegistry:devfrom
Open
Getting started instructions, proposal for Black formatting#34spra85 wants to merge 3 commits intoGreenBuildingRegistry:devfrom
spra85 wants to merge 3 commits intoGreenBuildingRegistry:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of these proposals may be unwelcome, but thought I'd propose the introduction of the popular
blackPython formatter in addition toflake8for consistent formatting.Went down this path largely to initially make an update to the README for instructions on getting started, which wasn't immediately clear.
Assuming it isn't user error on my side, would be happy to address these failures in the local
flake8command within this PR:Hoping to learn more about these since it seems like omitting the typing may have been intentional with lines like this?
However, there's mypy typing in most places within
normalize.py. Let me know if I can help finish the typing push in the other modules.Pending feedback on this PR, have another issue and PR related to address normalization I plan to submit for feedback.