Make pdf edge-to-edge and add logic to dodge window insets + test adjustments#647
Merged
Conversation
Canvas bitmap dimensions are capped by pdf.js render limits, so they can remain unchanged even when the displayed page zooms. Assert CSS page dimensions instead because they represent the visible page size users see. Keep zoom-out coverage gesture-driven by constraining UiAutomator pinches to the visible PDF content area. Edge-to-edge makes the WebView bounds extend behind the app bar and system bars, and UiObject2.pinchClose starts from the outer corners of those bounds. Zooming into these bounds results in no zoom happening.
JS bridge isn't guaranteed to be on main thread, but these values are written on main thread. (Note that other fields in the PdfViewer class with similar issues are marked as volatile in a different PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #588