feat: Add swift wasm CI targets to DataLoader #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r NIOCore works as expected.
…or the latest swift-nio dependency.
scottmarchant
commented
Jun 23, 2025
| @@ -13,7 +13,13 @@ let package = Package( | |||
| dependencies: [ | |||
| .package(url: "https://github.com/apple/swift-algorithms.git", from: "1.0.0"), | |||
| .package(url: "https://github.com/adam-fowler/async-collections", from: "0.0.1"), | |||
| .package(url: "https://github.com/apple/swift-nio.git", from: "2.0.0"), | |||
There was a problem hiding this comment.
This PR should NOT be merged until apple/swift-nio#3271 is merged and released.
This needs updated with the latest swift nio version once 3271 is merged and in a release.
There was a problem hiding this comment.
The nio PR is merged now, but still need a new swift-nio release containing the change. Until then, can't have a new minimum version with correct Package.resolved values.
scottmarchant
changed the title
32 tasks
scottmarchant
commented
Jun 23, 2025
| @@ -1,4 +1,4 @@ | |||
| // swift-tools-version:5.8 | |||
| // swift-tools-version:5.10.0 | |||
There was a problem hiding this comment.
Note, this is likely a breaking change for users of this repository.
|
The error for swift 5.8 should pass now that the ci change is merged.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is in DRAFT until required supporting changes are merged in swift-nio and GraphQLSwift/ci
Change summary
Added swift wasm as a CI target, to help prevent future breakages to swift wasm builds in DataLoader
Details
Notes
PR Dependencies
The following PR's must be merged before this PR can be merged:
Testing done
Verified new github workflow builds, once required upstream dependencies are patched in swift-nio
See https://github.com/PassiveLogic/DataLoader/actions/runs/15833601501/job/44631947127?pr=1
Remaining work