Replace composite deployment with the general workflow #1382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This reverts commit ac8b509
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the existing composite deployment with a more standard, separated workflow process. Key changes include updating the release workflow to use a new environment and removing the composite deploy-site action, as well as introducing a dedicated deploy workflow with explicit build and deploy steps.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Updated environment from "github-pages" to "maven-central" and removed the deploy-site action |
| .github/workflows/deploy.yml | Added a workflow_call trigger and restructured deployment steps including Gradle setup and site build |
Files not reviewed (1)
- .github/actions/deploy-site/action.yml: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/deploy.yml:4
- Ensure the YAML indentation for 'workflow_call:' is correct under the 'on:' key to avoid potential syntax errors.
workflow_call:
.github/workflows/release.yml:13
- [nitpick] Verify that changing the environment name from 'github-pages' to 'maven-central' is intentional and consistent with deployment targets across workflows.
name: maven-central
Goooler
changed the title
Goooler
changed the title
Member
Author
|
Workflow dispatch works well in https://github.com/GradleUp/shadow/actions/runs/14185980866. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.