fix: Iterate over QueryResults to populate cursor in DatastoreTemplate#4382
Open
TenorioStephano wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
fix: Iterate over QueryResults to populate cursor in DatastoreTemplate#4382TenorioStephano wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
TenorioStephano wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
…Template.java once it is not populate without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue 4348.
Resolution:
Iterate over key results to allow the use cursor in returned DatastoreResultsIterable.
Issue description:
DatastoreTemplate.java methods queryKeysSlice/queryKeysOrEntities do not iterate over results, and because of that, the cursor is not populated.
The results should be iterated in this reference, as it is already mentioned here.
Spring Cloud version 7.4.5