Skip to content

feat(spanner): add support for @ReadOnlyProperty #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bradperkins-gh wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −2
Open

feat(spanner): add support for @ReadOnlyProperty #4336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c28494
feat(spanner): add support for @ReadOnlyProperty
bradperkins-gh Feb 23, 2026
af8a410
Merge branch 'main' into support-read-only-property-spanner
bradperkins-gh Feb 25, 2026
80014c8
Merge branch 'main' into support-read-only-property-spanner
bradperkins-gh Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...n/java/com/google/cloud/spring/data/spanner/core/mapping/SpannerPersistentEntityImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ private Expression detectExpression() {

@Override
public void addPersistentProperty(SpannerPersistentProperty property) {
if (!property.isMapped()) {
if (!property.isMapped() || !property.isWritable()) {
return;
}
addPersistentPropertyToPersistentEntity(property);
Expand Down
10 changes: 9 additions & 1 deletion ...a/com/google/cloud/spring/data/spanner/core/mapping/SpannerPersistentEntityImplTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import java.util.List;
import org.junit.jupiter.api.Test;
import org.springframework.context.ApplicationContext;
import org.springframework.data.annotation.ReadOnlyProperty;
import org.springframework.core.NestedExceptionUtils;
import org.springframework.data.core.TypeInformation;
import org.springframework.data.mapping.PersistentProperty;
Expand Down Expand Up @@ -225,11 +226,15 @@ void testIgnoredProperty() {
t.id = "a";
t.something = "a";
t.notMapped = "b";
t.readOnly = "c";
SpannerPersistentEntity p = new SpannerMappingContext().getPersistentEntity(TestEntity.class);
PersistentPropertyAccessor accessor = p.getPropertyAccessor(t);
p.doWithProperties(
(SimplePropertyHandler)
property -> assertThat(accessor.getProperty(property)).isNotEqualTo("b"));
property -> {
assertThat(accessor.getProperty(property)).isNotEqualTo("b");
assertThat(accessor.getProperty(property)).isNotEqualTo("c");
});
}

@Test
Expand Down Expand Up @@ -484,6 +489,9 @@ private static class TestEntity {
String something;

@NotMapped String notMapped;

@ReadOnlyProperty
String readOnly;
}

private static class EntityNoCustomName {
Expand Down