Skip to content

docs: Fix documented Oracle NCLOB sample - #1815

Merged
nj1973 merged 4 commits into
developfrom
1814-add-tests-for-oracle-lob_validations-sample
Aug 20, 2026
Merged

docs: Fix documented Oracle NCLOB sample#1815
nj1973 merged 4 commits into
developfrom
1814-add-tests-for-oracle-lob_validations-sample

Conversation

@nj1973

@nj1973 nj1973 commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Description of changes

This PR adds tests for the documented Oracle LOB samples. From having these tests we found that the NCLOB sample was wrong so this PR also fixes the documentation.

Issues to be closed

Closes #1814

Checklist

  • I have followed the CONTRIBUTING Guide.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated any relevant documentation to reflect my changes, if applicable
  • I have added unit and/or integration tests relevant to my change as needed
  • I have already checked locally that all unit tests and linting are passing (use the tests/local_check.sh script)
  • I have manually executed end-to-end testing (E2E) with the affected databases/engines

@nj1973 nj1973 linked an issue Aug 17, 2026 that may be closed by this pull request
@nj1973

nj1973 commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator Author

/gcbrun

@renzokuken renzokuken left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch on DBMS_CRYPTO not being universal

@nj1973
nj1973 merged commit 54ce3ca into develop Aug 20, 2026
10 of 11 checks passed
@nj1973
nj1973 deleted the 1814-add-tests-for-oracle-lob_validations-sample branch August 20, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests proving the Oracle lob_validations sample solution

2 participants