-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(Storage): adding retry configuration example. #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! nice work! One small suggestion (and fixing the sample tag) and we can merge this!
Are these options dependent on googleapis/google-cloud-php#8489? If so, we can't merge this until that PR is merged and released, and we'll want to update storage/composer.json
with the new minimum version
Yes, they are as I added some fixes and new params in aforementioned PR. |
So we'll need to wait until we release the next version of the Storage client library in googleapis/google-cloud-php#8520. Then, ideally, we'd update |
@bshaffer looks like the new version is released - I've bumped dependency to |
Example on how to pass configuration related to retries to
StorageClient
and operations that include:Fixes googleapis/google-cloud-php#8309.