chore(modelarmor): added floorsettings tests #2144
Conversation
product-auto-label
bot
added
api: modelarmor
|
NOTE: Please set following environment variables required for running tests: |
utsav1810
added
kokoro:run
kokoro-team
removed
kokoro:run
modelarmor/test/modelarmorTest.php
Outdated
| /** | ||
| * Reset project floor settings to default values | ||
| */ | ||
| protected static function resetProjectFloorSettings(): void |
There was a problem hiding this comment.
The code across all the methods of type reset...FloorSettings seems redundant. Can you please extract the common code in a separate method & use it for Project/Folder/Organization.
There was a problem hiding this comment.
Updated logic for resetting floor settings to remove redundant logic.
There was a problem hiding this comment.
NOTE: Please set following environment variables required for running tests: MA_FOLDER_ID:
695279264361MA_ORG_ID:951890214235
Which project are these credentials for? I used these for the standard test project (php-docs-samples-kokoro) and was unable to get them to work.
modelarmor/test/modelarmorTest.php
Outdated
| self::$organizationId = getenv('MA_ORG_ID'); | ||
| self::$folderId = getenv('MA_FOLDER_ID'); |
There was a problem hiding this comment.
let's use requireEnv for these, that way people running the tests will know they're required:
| self::$organizationId = getenv('MA_ORG_ID'); | |
| self::$folderId = getenv('MA_FOLDER_ID'); | |
| self::$organizationId = self::requireEnv('MA_ORG_ID'); | |
| self::$folderId = self::requireEnv('MA_FOLDER_ID'); |
Did not get this. |
Added floor settings tests as issue b/424365799 is fixed.
Added tests for